From 49386dd851025155224d03afb88d65d08aeca463 Mon Sep 17 00:00:00 2001
From: ZtereoHYPE <57519662+ZtereoHYPE@users.noreply.github.com>
Date: Thu, 13 Oct 2022 11:59:47 +0200
Subject: [PATCH] change: cleanup + perf experiments

---
 .../codes/ztereohype/example/ExampleMod.java    |  4 +---
 .../example/mixin/MixinStarRendering.java       |  2 +-
 .../example/sky/nebula/NebulaSkyboxPainter.java |  2 +-
 .../codes/ztereohype/example/sky/star/Star.java | 17 +++++++++++++++++
 .../ztereohype/example/sky/star/Starbox.java    |  2 +-
 5 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/src/main/java/codes/ztereohype/example/ExampleMod.java b/src/main/java/codes/ztereohype/example/ExampleMod.java
index ddc9153..fed669f 100644
--- a/src/main/java/codes/ztereohype/example/ExampleMod.java
+++ b/src/main/java/codes/ztereohype/example/ExampleMod.java
@@ -8,7 +8,5 @@ public class ExampleMod implements ModInitializer {
     public static SkyManager skyManager = new SkyManager();
 
     @Override
-    public void onInitialize() {
-//        skyManager.generateSky(123L);
-    }
+    public void onInitialize() {}
 }
diff --git a/src/main/java/codes/ztereohype/example/mixin/MixinStarRendering.java b/src/main/java/codes/ztereohype/example/mixin/MixinStarRendering.java
index 08b73ad..41f9689 100644
--- a/src/main/java/codes/ztereohype/example/mixin/MixinStarRendering.java
+++ b/src/main/java/codes/ztereohype/example/mixin/MixinStarRendering.java
@@ -29,7 +29,7 @@ public abstract class MixinStarRendering {
 
     @Inject(at = @At("HEAD"), method = "createStars", cancellable = true)
     private void generateStars(CallbackInfo ci) {
-        ExampleMod.skyManager.generateSky(123L);
+        ExampleMod.skyManager.generateSky(321L);
         starBuffer = new VertexBuffer();
         ExampleMod.skyManager.tick(ticks, starBuffer);
         ci.cancel();
diff --git a/src/main/java/codes/ztereohype/example/sky/nebula/NebulaSkyboxPainter.java b/src/main/java/codes/ztereohype/example/sky/nebula/NebulaSkyboxPainter.java
index d3ca0b4..0ae0dba 100644
--- a/src/main/java/codes/ztereohype/example/sky/nebula/NebulaSkyboxPainter.java
+++ b/src/main/java/codes/ztereohype/example/sky/nebula/NebulaSkyboxPainter.java
@@ -9,7 +9,7 @@ import java.awt.*;
 
 public class NebulaSkyboxPainter extends SkyboxPainter {
     private static final float SCALING_FACTOR = 1f;
-    private static final float BASE_NOISE_AMOUNT = 0.7f; // the amount of base noise to keep
+    private static final float BASE_NOISE_AMOUNT = 0.56f; // the amount of base noise to keep
 
     private final Gradient nebulaGradient;
 
diff --git a/src/main/java/codes/ztereohype/example/sky/star/Star.java b/src/main/java/codes/ztereohype/example/sky/star/Star.java
index 56951ac..8ee3134 100644
--- a/src/main/java/codes/ztereohype/example/sky/star/Star.java
+++ b/src/main/java/codes/ztereohype/example/sky/star/Star.java
@@ -101,17 +101,34 @@ public class Star {
         float ae3 = firstVertexDistance * latitudeCos;
         float ae4 = secondVertexDistance * latitudeCos;
 
+        // 0
         bufferBuilder.vertex(xCoord + ae1 * longitudeSin - secondVertexDistance * longitudeCos, yCoord + firstVertexDistance * latitudeSin, zCoord + secondVertexDistance * longitudeSin + ae1 * longitudeCos)
                      .color(r, g, b, 255)
                      .endVertex();
+        // 1
         bufferBuilder.vertex(xCoord + ae2 * longitudeSin - thirdVertexDistance * longitudeCos, yCoord + secondVertexDistance * latitudeSin, zCoord + thirdVertexDistance * longitudeSin + ae2 * longitudeCos)
                      .color(r, g, b, 255)
                      .endVertex();
+
         bufferBuilder.vertex(xCoord + ae3 * longitudeSin - fourthVertexDistance * longitudeCos, yCoord + thirdVertexDistance * latitudeSin, zCoord + fourthVertexDistance * longitudeSin + ae3 * longitudeCos)
                      .color(r, g, b, 255)
                      .endVertex();
+
+        // 3
         bufferBuilder.vertex(xCoord + ae4 * longitudeSin - firstVertexDistance * longitudeCos, yCoord + fourthVertexDistance * latitudeSin, zCoord + firstVertexDistance * longitudeSin + ae4 * longitudeCos)
                      .color(r, g, b, 255)
                      .endVertex();
+//        // 1
+//        bufferBuilder.vertex(xCoord + ae2 * longitudeSin - thirdVertexDistance * longitudeCos, yCoord + secondVertexDistance * latitudeSin, zCoord + thirdVertexDistance * longitudeSin + ae2 * longitudeCos)
+//                     .color(r, g, b, 255)
+//                     .endVertex();
+//        // 2
+//        bufferBuilder.vertex(xCoord + ae3 * longitudeSin - fourthVertexDistance * longitudeCos, yCoord + thirdVertexDistance * latitudeSin, zCoord + fourthVertexDistance * longitudeSin + ae3 * longitudeCos)
+//                     .color(r, g, b, 255)
+//                     .endVertex();
+//        // 3
+//        bufferBuilder.vertex(xCoord + ae4 * longitudeSin - firstVertexDistance * longitudeCos, yCoord + fourthVertexDistance * latitudeSin, zCoord + firstVertexDistance * longitudeSin + ae4 * longitudeCos)
+//                     .color(r, g, b, 255)
+//                     .endVertex();
     }
 }
diff --git a/src/main/java/codes/ztereohype/example/sky/star/Starbox.java b/src/main/java/codes/ztereohype/example/sky/star/Starbox.java
index 9a982e0..5f8c022 100644
--- a/src/main/java/codes/ztereohype/example/sky/star/Starbox.java
+++ b/src/main/java/codes/ztereohype/example/sky/star/Starbox.java
@@ -26,7 +26,7 @@ public class Starbox {
         generateStars(randomSource);
     }
 
-    public void generateStars(RandomSource randomSource) {
+    private void generateStars(RandomSource randomSource) {
         ImprovedNoise noise = new ImprovedNoise(randomSource);
 
         for (int i = 0; i < this.stars; ++i) {