Jonas_Jones/selfhosted-overleaf-project-share
1
0
Fork 0
mirror of https://github.com/JonasunderscoreJones/selfhosted-overleaf-project-share.git synced 2025-10-24 09:39:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed error handling on wrong symlink directory

Browse source
This commit is contained in:
Jonas_Jones 2025-06-09 21:34:46 +02:00
parent 9143d783ba
commit d638dfe38c
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
serve.py
View file

@ -31,7 +31,7 @@ def get_project_directory(project_id):
if GRAB_SYMLINKS and not os.path.exists(project_dir): if GRAB_SYMLINKS and not os.path.exists(project_dir):
# If the project does not exist in the projects dir, check if it exists in the symlinks dir # If the project does not exist in the projects dir, check if it exists in the symlinks dir
if not os.path.exists(SYMLINK_DIR) or not os.path.isdir(SYMLINK_DIR): if not os.path.exists(SYMLINK_DIR) or not os.path.isdir(SYMLINK_DIR):
return "" return None
# Find the symlink directory that starts with the project_id # Find the symlink directory that starts with the project_id
symlink_dirs = [d for d in os.listdir(SYMLINK_DIR) if os.path.isdir(os.path.join(SYMLINK_DIR, d))] symlink_dirs = [d for d in os.listdir(SYMLINK_DIR) if os.path.isdir(os.path.join(SYMLINK_DIR, d))]
# Sort by last modified time (descending) # Sort by last modified time (descending)
@ -56,6 +56,8 @@ class CustomHandler(http.server.SimpleHTTPRequestHandler):
project_id = parts[0] project_id = parts[0]
project_dir = get_project_directory(project_id) project_dir = get_project_directory(project_id)
if not project_dir:
return os.path.join(BASE_DIR, "404.html")
# Check .staticshare restriction # Check .staticshare restriction
if STATIC_SHARE_RESTRICTION: if STATIC_SHARE_RESTRICTION:
staticshare_path = os.path.join(project_dir, ".staticshare") staticshare_path = os.path.join(project_dir, ".staticshare")
@ -88,6 +90,14 @@ class CustomHandler(http.server.SimpleHTTPRequestHandler):
project_dir = get_project_directory(project_id) project_dir = get_project_directory(project_id)
if not project_dir:
self.send_response(404)
self.send_header("Content-type", "text/html")
self.end_headers()
with open(os.path.join(BASE_DIR, "404.html"), "rb") as f:
self.wfile.write(f.read())
return
if STATIC_SHARE_RESTRICTION: if STATIC_SHARE_RESTRICTION:
staticshare_path = os.path.join(project_dir, ".staticshare") staticshare_path = os.path.join(project_dir, ".staticshare")
if not os.path.isfile(staticshare_path): if not os.path.isfile(staticshare_path):